Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: put conn back #164

Merged
merged 1 commit into from
Jun 20, 2022
Merged

fix: put conn back #164

merged 1 commit into from
Jun 20, 2022

Conversation

hzliangbin
Copy link
Contributor

ref: https://github.com/cectc/dbpack/issues/

Ⅰ. Describe what this PR did

put connection back if no longer need it

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

Codecov Report

Merging #164 (bc2a185) into dev (7a213c2) will not change coverage.
The diff coverage is 66.66%.

❗ Current head bc2a185 differs from pull request most recent head 81d72fc. Consider uploading reports for the commit 81d72fc to get more accurate results

@@           Coverage Diff           @@
##              dev     #164   +/-   ##
=======================================
  Coverage   42.29%   42.29%           
=======================================
  Files          73       73           
  Lines        8342     8342           
=======================================
  Hits         3528     3528           
  Misses       4483     4483           
  Partials      331      331           
Impacted Files Coverage Δ
pkg/filter/dt/filter_http.go 16.34% <66.66%> (ø)
pkg/filter/dt/filter_mysql.go 1.51% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a213c2...81d72fc. Read the comment docs.

@fatelei
Copy link
Collaborator

fatelei commented Jun 20, 2022

LGTM

@dk-lockdown dk-lockdown merged commit b1c8330 into CECTC:dev Jun 20, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants