Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: construct a TraceContext with the correct traceparent #203

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

dk-lockdown
Copy link
Collaborator

@dk-lockdown dk-lockdown commented Jul 18, 2022

ref: #50

Ⅰ. Describe what this PR did

Get the full trace of distributed transaction execution

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

image

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2022

Codecov Report

Merging #203 (7a39aaf) into dev (d703959) will increase coverage by 0.02%.
The diff coverage is 25.56%.

❗ Current head 7a39aaf differs from pull request most recent head fd5136a. Consider uploading reports for the commit fd5136a to get more accurate results

@@            Coverage Diff             @@
##              dev     #203      +/-   ##
==========================================
+ Coverage   42.80%   42.83%   +0.02%     
==========================================
  Files          81       81              
  Lines        9554     9552       -2     
==========================================
+ Hits         4090     4092       +2     
+ Misses       5058     5054       -4     
  Partials      406      406              
Impacted Files Coverage Δ
pkg/executor/sharding.go 0.00% <0.00%> (ø)
pkg/filter/dt/exec/prepare_delete.go 46.29% <0.00%> (ø)
pkg/filter/dt/exec/prepare_insert.go 30.76% <0.00%> (ø)
pkg/filter/dt/exec/prepare_update.go 51.08% <0.00%> (ø)
pkg/filter/dt/exec/query_delete.go 51.06% <0.00%> (ø)
pkg/filter/dt/exec/query_insert.go 28.72% <0.00%> (ø)
pkg/filter/dt/exec/query_update.go 53.84% <0.00%> (ø)
pkg/filter/dt/filter_http.go 15.74% <0.00%> (ø)
pkg/filter/dt/filter_mysql.go 1.58% <0.00%> (ø)
pkg/filter/dt/filter_mysql_prepare.go 0.00% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d703959...fd5136a. Read the comment docs.

Copy link
Collaborator

@bohehe bohehe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fatelei fatelei merged commit 3ecb2cc into CECTC:dev Jul 19, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants