Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support release savepoint #251

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

dk-lockdown
Copy link
Collaborator

@dk-lockdown dk-lockdown commented Aug 18, 2022

ref: https://github.com/cectc/dbpack/issues/

Ⅰ. Describe what this PR did

release savepoint must be executed on the same tx connection
image

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2022

Codecov Report

Merging #251 (04f84c1) into dev (4de4eb3) will decrease coverage by 0.06%.
The diff coverage is 24.00%.

@@            Coverage Diff             @@
##              dev     #251      +/-   ##
==========================================
- Coverage   43.18%   43.11%   -0.07%     
==========================================
  Files          82       82              
  Lines        9827     9847      +20     
==========================================
+ Hits         4244     4246       +2     
- Misses       5148     5166      +18     
  Partials      435      435              
Impacted Files Coverage Δ
pkg/executor/sharding.go 0.00% <0.00%> (ø)
pkg/executor/read_write_splitting.go 46.30% <25.00%> (-1.89%) ⬇️
pkg/executor/single_db.go 48.85% <25.00%> (-2.37%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dk-lockdown dk-lockdown changed the title fix: should return err when there is no post filter fix: support release savepoint Aug 18, 2022
@dk-lockdown dk-lockdown added the bug Something isn't working label Aug 18, 2022
@dk-lockdown dk-lockdown merged commit 63b19cb into CECTC:dev Aug 18, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants