feat: support check conn liveness #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #260 +/- ##
==========================================
+ Coverage 43.12% 43.77% +0.64%
==========================================
Files 82 82
Lines 9845 9885 +40
==========================================
+ Hits 4246 4327 +81
+ Misses 5164 5106 -58
- Partials 435 452 +17
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bohehe
reviewed
Aug 28, 2022
|
|
||
| sysConn, ok := conn.(syscall.Conn) | ||
| if !ok { | ||
| return nil |
There was a problem hiding this comment.
better to return error instead of nil?
There was a problem hiding this comment.
Only syscall.Conn SyscallConn() func return RawConn, we use RawConn to check connection alive. If a connection is't syscall.Conn does't mean it can't read.
fatelei
approved these changes
Aug 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: https://github.com/cectc/dbpack/issues/
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews