Energy-conserving EQP #177
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cval26
commented
Jun 28, 2023
cval26
commented
Jun 28, 2023
| Vector & rv, Vector & re) | ||
| { | ||
| const int nqp = ir->GetNPoints(); | ||
| const int dim = trial_fe.GetDim(); // TODO: shouldn't it be the dimension of test_fe? |
There was a problem hiding this comment.
Shouldn't dim be the dimension of the velocity space test_fe, instead of the energy space trial_fe? In general, my understanding is that test_fe has dimension 3, while trial_fe has dimension 1.
Variable dim is used to set the size of several vectors holding velocity coefficient values, so I'm not sure why the dimension of trial_fe is used.
cval26
commented
Jun 30, 2023
cval26
commented
Jun 30, 2023
cval26
commented
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm opening this draft PR so that you can stay up to date with my changes in the code, and so that I can ask you questions about specific parts of the code that I'm unsure of. I'll add comments to the parts of the code I have questions on.
I'll push new changes as I implement them so that we can discuss them. Once we have a correct implementation I can go back and edit the commit history so that it's easier to review.
The indentation in some parts of the code seems to be off in the diff files. I'm not sure why; it doesn't look like that in my editor.
Changes made so far: