Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OperatorAtPoints #1390

Merged
merged 4 commits into from
Nov 30, 2023
Merged

OperatorAtPoints #1390

merged 4 commits into from
Nov 30, 2023

Conversation

jeremylt
Copy link
Member

@jeremylt jeremylt commented Nov 2, 2023 •
edited
Loading

Super, duper WIP

  • Add interface function signatures
  • Update field update logic for AtPoints
  • Add basic CPU impl (probably easiest to do 1 element at a time like in opt)
  • Add basic t-5* tests
  • Convert PETSc DMSwarm example

jedbrown
jedbrown reviewed Nov 7, 2023
View reviewed changes
interface/ceed-operator.c Outdated Show resolved Hide resolved
@jeremylt
Copy link
Member Author

jeremylt commented Nov 9, 2023

Ok, I have hacked in the rough internals. Untested, undebugged, etc

zatkins-dev
zatkins-dev reviewed Nov 12, 2023
View reviewed changes
Copy link
Collaborator

@zatkins-dev zatkins-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I think this looks great, it definitely clarifies the overall interface design.

backends/ref/ceed-ref-operator.c Show resolved Hide resolved
interface/ceed-operator.c Outdated Show resolved Hide resolved
jeremylt
jeremylt commented Nov 15, 2023
View reviewed changes
tests/t591-operator.h Outdated Show resolved Hide resolved
@jeremylt

This comment was marked as outdated.

Sign in to view
jeremylt
jeremylt commented Nov 16, 2023
View reviewed changes
tests/t591-operator.h Outdated Show resolved Hide resolved
@jeremylt jeremylt self-assigned this Nov 17, 2023
zatkins-dev
zatkins-dev approved these changes Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@zatkins-dev zatkins-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that with tests passing, I'm good with merging this now to unblock parallel development. I anticipate smaller fixes will be needed along the way, but this should get us most of the way there.

@jeremylt jeremylt merged commit 48acf71 into main Nov 30, 2023
23 of 24 checks passed
@jeremylt jeremylt deleted the jeremy/operator-at-points branch November 30, 2023 17:26
@jeremylt jeremylt mentioned this pull request Dec 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedbrown jedbrown jedbrown left review comments

@zatkins-dev zatkins-dev zatkins-dev approved these changes

Assignees

@jeremylt jeremylt

Labels
1-In Review CPU design interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jeremylt @jedbrown @zatkins-dev