Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tests to reduce use of output #797

Merged
merged 3 commits into from
Aug 2, 2021
Merged

Refactor tests to reduce use of output #797

merged 3 commits into from
Aug 2, 2021

Conversation

jeremylt
Copy link
Member

@jeremylt jeremylt commented Aug 2, 2021

This PR adjusts the C tests so that only the tests of the Ceed*View functions make output.

@jeremylt jeremylt self-assigned this Aug 2, 2021
@jeremylt jeremylt added 1-In Review and removed 0-WIP labels Aug 2, 2021
@jeremylt jeremylt force-pushed the jeremy/less-output branch 4 times, most recently from 35778b5 to 6fd4301 Compare August 2, 2021 20:43
@jeremylt jeremylt added 0-WIP and removed 1-In Review labels Aug 2, 2021
@jeremylt
Copy link
Member Author

jeremylt commented Aug 2, 2021

Woops, forgot the Python tests

@jeremylt jeremylt added 1-In Review and removed 0-WIP labels Aug 2, 2021
@jeremylt
Copy link
Member Author

jeremylt commented Aug 2, 2021

Ok, all set now

else
diff=diff-(10+i-1)
endif
if (abs(diff) > 1.0D-15) then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we refrain from hard-coding new constants, or fix all these in a batch with #778 #788 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking this could be fixed over there

tests/t208-elemrestriction-f.f90 Outdated Show resolved Hide resolved
@jeremylt jeremylt merged commit e508ec0 into main Aug 2, 2021
@jeremylt jeremylt deleted the jeremy/less-output branch August 2, 2021 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants