Element Restriction Oriented #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremylt
reviewed
Feb 2, 2022
jeremylt
reviewed
Feb 2, 2022
jeremylt
reviewed
Feb 2, 2022
jeremylt
reviewed
Feb 3, 2022
jeremylt
reviewed
Feb 3, 2022
jeremylt
reviewed
Feb 3, 2022
jeremylt
reviewed
Feb 3, 2022
Co-authored-by: Jeremy L Thompson <jeremy@jeremylt.org>
Co-authored-by: Jeremy L Thompson <jeremy@jeremylt.org>
rezgarshakeri
force-pushed
the
rezgar/oriented-restr
branch
from
1635b39
to
c774505
Compare
jeremylt
approved these changes
Feb 4, 2022
:), thanks for your comments. @jedbrown do you have any comments? |
jedbrown
approved these changes
Feb 4, 2022
Yeah, I was hoping changing the function signature to static inline int CeedElemRestrictionApply_Ref_Core(CeedElemRestriction r,
const CeedInt num_comp, const CeedInt blk_size, const CeedInt comp_stride,
CeedInt start, CeedInt stop, CeedTransposeMode t_mode, const bool is_oriented,
CeedVector u, CeedVector v, CeedRequest *request)but not creating a bunch of separate variants would be enough for all of the compilers we use to fairly reliably generate good code. |
|
Why CI is failing? |
|
CI on LV is flakey |
jedbrown
approved these changes
Feb 7, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
CeedElemRestrictionCreateOrientedto flip dofs (multiply by -1) if needed for H(div) implementation.