Adding visulization (Merging #109) #143
Conversation
…ssing tests. Adding new file to /mcdc visulizer.py
|
There was a problem hiding this comment.
Looks good to me. Thanks @jpmorgan98! And thanks @RohanPankaj!
{{ message }}
Merged
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 22, 2023
Closed
Closed
ilhamv
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding visualization functionality and an example script to do it on a Godiva model.
This PR will elevate a new
mcdc.visualization()as a new top level command for use in input scripts which will render a given model thru time. To see an example of this feature navigate toexamples/ godiva-mockup-visulizationand runpython input.py.New dependence are required for this functionality (
ngsolve&distinctipy) and these have been added to the testing functionality as well as the install script.No automatic testing is required or currently implemented. Tho Rhoan had originally included a script which could be brought into automatic unit testing
Future development is needed to flesh this out to work with other models as well as to render results. The intention of this PR is to get this functionality into main.
Thanks to @RohanPankaj for doing most of this work (see quashed PR #109). I had to do some repo funny business to get all the tests working and this seemed easer than submitting a PR to his private github to update #109. This also closes issue #138