Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use service worker "postMessage" #7

Merged
merged 1 commit into from
Oct 7, 2019
Merged

Use service worker "postMessage" #7

merged 1 commit into from
Oct 7, 2019

Conversation

iainjreid
Copy link
Contributor

This commit removes the original server style implementation for the
browser interface, and replaces it with a more appropriate messaging
setup.

@iainjreid
Use service worker "postMessage"
218262f 
This commit removes the original server style implementation for the
browser interface, and replaces it with a more appropriate messaging
setup.
@iainjreid iainjreid added the enhancement New feature or request label Oct 2, 2019
@iainjreid iainjreid self-assigned this Oct 2, 2019
wilkinsonjack1993
wilkinsonjack1993 approved these changes Oct 3, 2019
View reviewed changes
Copy link

@wilkinsonjack1993 wilkinsonjack1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! (Although this is my first time in this area so would be worth another set of eyes :) )

Motonstron
Motonstron approved these changes Oct 4, 2019
View reviewed changes
Copy link

@Motonstron Motonstron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@iainjreid iainjreid merged commit 1019f44 into master Oct 7, 2019
@Motonstron Motonstron deleted the use-post-message branch October 7, 2019 12:03
@iainjreid iainjreid restored the use-post-message branch October 18, 2019 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Motonstron Motonstron Motonstron approved these changes

@wilkinsonjack1993 wilkinsonjack1993 wilkinsonjack1993 approved these changes

@j-bridger j-bridger j-bridger approved these changes

Assignees

@iainjreid iainjreid

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@iainjreid @Motonstron @wilkinsonjack1993 @j-bridger