fields: rule for 695__ #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
topless
commented
Mar 28, 2019
topless
commented
- for field 695__ when subfield 9 is LANL EDS then subfield a is stored in: arxiv_eprints/categories
- resolves Add rule 695__ when $$9LANL EDS #198
topless
force-pushed
the
198-rule-for-695
branch
from
d997298
to
0617868
Compare
kpsherva
reviewed
Mar 29, 2019
| _arxiv_eprints = self.get('arxiv_eprints', []) | ||
| category = check_category('a', value) | ||
| if not _arxiv_eprints: | ||
| raise ManualMigrationRequired(message='037__ is missing') |
There was a problem hiding this comment.
Could you add to the tests checking this case to make coverage green?
There was a problem hiding this comment.
I have added a couple of tests for all the raised exceptions
| if category not in _entry['categories']: | ||
| _entry['categories'].append(category) | ||
| return _arxiv_eprints | ||
| raise IgnoreKey('arxiv_eprints') |
There was a problem hiding this comment.
I think we should raise UnexpectedValue here
There was a problem hiding this comment.
I cleaned up a bit the way we raise exceptions, Unexpected value is raised where expected
* for field 695__ when subfield 9 is LANL EDS then subfield a is stored in: arxiv_eprints/categories * added tests for the newly introduced cases * resolves CERNDocumentServer#198
topless
force-pushed
the
198-rule-for-695
branch
from
0617868
to
8663b5d
Compare
kpsherva
approved these changes
Mar 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.