Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multipart: improved volume number parser #244

Merged
merged 2 commits into from
Sep 2, 2019
Merged

multipart: improved volume number parser #244

merged 2 commits into from
Sep 2, 2019

Conversation

equadon
Copy link

@equadon equadon commented Aug 30, 2019 •
edited

  • Also parse volume numbers in 020__
  • Raise exception if an invalid role was found
  • Fix bugs causing document rectype to fail

Closes #240

@equadon equadon force-pushed the parse-volume-number branch 7 times, most recently from c7fcc03 to de39e51 Compare August 30, 2019 12:49
@equadon
multipart: improved volume number parser
270ac84 
* Also parse volume numbers in 020__ using the same method
@equadon equadon mentioned this pull request Aug 30, 2019
Merged
@equadon equadon marked this pull request as ready for review August 30, 2019 15:27
@equadon equadon force-pushed the parse-volume-number branch 2 times, most recently from c3e8a0c to 2eb6084 Compare August 30, 2019 15:49
@equadon
book: fix bug causing errors
bb8e5b7 
* Raise exception if an invalid role was found
@kpsherva kpsherva merged commit c86f396 into CERNDocumentServer:books Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpsherva kpsherva kpsherva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@equadon @kpsherva