document: implement rule 088__ barcodes #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
equadon
force-pushed
the
fix-088-rule
branch
4 times, most recently
from
bc90bc6
to
2758c97
Compare
kpsherva
reviewed
Sep 3, 2019
| barcode=val_x | ||
| )) | ||
| self['_migration'] = _migration | ||
|
|
There was a problem hiding this comment.
just for clarity, you should put here the IgnoreKey for barcodes because right now it returns none and @out_strip cleans it, Ignore Key would be better
There was a problem hiding this comment.
@out_strip is now removed and also raising IgnoreKey.
equadon
force-pushed
the
fix-088-rule
branch
from
2758c97
to
370cd55
Compare
kpsherva
approved these changes
Sep 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #243