global: upgrade invenio-app-ils #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kpsherva
commented
Jan 10, 2024
•
kpsherva
commented
- search: remove es6 compatibility
- closes Upgrade invenio packages inveniosoftware/invenio-app-ils#1188
* search: remove es6 compatibility
* installation: upgrade frontend dependencies
kpsherva
force-pushed
the
upgrade-ils
branch
2 times, most recently
from
62c6a6b
to
9ff3662
Compare
ntarocco
approved these changes
Jan 19, 2024
| idna==3.4 | ||
| importlib-metadata==4.8.3 | ||
| importlib-resources==5.4.0 | ||
| github3.py==4.0.1 |
There was a problem hiding this comment.
We should not need github?
There was a problem hiding this comment.
invenio-oauthclient requires it :)
| importlib-metadata==4.8.3 | ||
| importlib-resources==5.4.0 | ||
| github3.py==4.0.1 | ||
| greenlet==3.0.3 |
There was a problem hiding this comment.
are we sure about greenlet?
There was a problem hiding this comment.
thats a good question, it gets installed with some other dependency, but pip does not want to disclose which dependency installs it:
| "axios": "^0.21.0", | ||
| "ajv": "^8.0.0", | ||
| "ajv-keywords": "^5.0.0", | ||
| "axios": "^1.6.0", |
There was a problem hiding this comment.
I have vague memories that axios v1 was breaking some stuff, I guess that the UI app is working fine :)
There was a problem hiding this comment.
it is working fine, I tested GET and POST
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.