This repository has been archived by the owner on Feb 28, 2022. It is now read-only.
[ci skip] WIP: Refactoring for Invenio-Videos #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egabancho
force-pushed
the
object-oriented-refactoring
branch
2 times, most recently
from
7f1b606
to
681c81d
Compare
egabancho
force-pushed
the
object-oriented-refactoring
branch
from
681c81d
to
867ca45
Compare
|
Should solve: |
ntarocco
reviewed
May 4, 2018
| CDS_SORENSON_BIG_FILE_THRESHOLD = 21474836480 # 20 Gb | ||
| """Size after which a file is consider big. | ||
|
|
||
| Sorenson machines are heterogeneous, two machines have a big disk (1Tb) and the |
There was a problem hiding this comment.
MINOR: here you describe the specific CERN config, I don't know if you want to be more generic here and document this in our doc maybe
ntarocco
reviewed
May 4, 2018
|
|
||
| CDS_SORENSON_QUEUES = { | ||
| 'default': '88b51dfc-fa33-4d0e-8ea0-934fc31dc4a2', | ||
| 'big_files': '064153dd-ade2-4824-8458-88e6ea03d395', |
There was a problem hiding this comment.
are these the right queues ids already?
There was a problem hiding this comment.
I am not sure, I took them from the issue I opened some time ago #39
|
Question: I see it is WIP, and it is missing code, right? It is not just waiting for tests or other... |
|
Yeap, it's still missing some parts, i.e. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs inveniosoftware/invenio-files-rest#167