Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL reputation module #878

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

URL reputation module #878

wants to merge 7 commits into from

Conversation

RasenRhino
Copy link
Contributor

@RasenRhino RasenRhino commented Mar 27, 2024

I have opened this PR for code review and further improvements. This is an abstract idea on how I plan to proceed with this issue .
testing it alongside.

TODOS:

  • add the data to the database part
  • check for the urls (the no 404 is relatively easy so have left it for last)

The test script that has been translated to this module can be looked at here
one can probably use this for testing purposes. just a simple html website with a few bad urls which I was using while developing this script. just serve it through any live server and point it to the base url.

@kazet
Copy link
Member

kazet commented Apr 18, 2024

The overall logic seems fine. The main two things to improve would be:

  • add reporting capabilities, so that malicious outgoing links would be included in automatic reports generated by Artemis
  • research what methods of identifying bad URLs are available - the one you chose detects only direct malware download links as malicious, which looks insufficient to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants