Apply suggestions from code review

Co-authored-by: Hubert Jasudowicz <hubert.jasudowicz@cert.pl>
CERT-Polska · Sep 13, 2021 · 2a2b1e1 · 2a2b1e1
1 parent b03b7c3
commit 2a2b1e1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/drakrun/drakrun/apiscout.py b/drakrun/drakrun/apiscout.py
@@ -98,7 +98,7 @@ def build_static_apiscout_profile(
 
     for dll_basename in dll_basename_list:
         filepath = Path(apiscout_profile_dir) / f"{dll_basename}.json"
-        if not os.path.isfile(filepath):
+        if not filepath.isfile():
             log.warning(
                 f"'{filepath}' not found. Is there a problem with profiles generation?"
             )

diff --git a/drakrun/drakrun/draksetup.py b/drakrun/drakrun/draksetup.py
@@ -1246,15 +1246,15 @@ def do_import_full(mc, name, bucket, zpool):
     profiles_prefix = f"{name}/profiles/"
     for object in mc.list_objects(bucket, prefix=profiles_prefix):
         # Strip profiles prefix
-        profile_name = object.object_name[len(profiles_prefix) :]
+        profile_name = object.object_name[len(profiles_prefix):]
         mc.fget_object(
             bucket, object.object_name, os.path.join(PROFILE_DIR, profile_name)
         )
 
     apiscout_profile_prefix = f"{name}/apiscout_profile/"
     for object in mc.list_objects(bucket, prefix=apiscout_profile_prefix):
         # Strip apiscout profile prefix
-        filename = object.object_name[len(apiscout_profile_prefix) :]
+        filename = object.object_name[len(apiscout_profile_prefix):]
         mc.fget_object(
             bucket, object.object_name, os.path.join(APISCOUT_PROFILE_DIR, filename)
         )