-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Mquery to typed config library #324
Conversation
Ok, i'm feeling lucky. I'm submitting this PR for review and maybe merging. This changes the current mquery configuration mechanism from editing [redis]
host=redis-server.example.com
[mquery]
backend=tcp://ursadb-server.example.com:9281
plugins=plugins.archive:GzipPlugin This solution has some downsides:
Despite this, I like it because:
I've also added a signifcant amount of documentation, to explain mquery config. But this chnage will have to be stressed in the release notes, so users that decide to upgrade know to be careful about that. |
@@ -115,6 +109,9 @@ jobs: | |||
run: docker-compose up --scale daemon=1 --build -d | |||
- name: run e2e tests | |||
run: docker run --net mquery_default -v $(readlink -f ./samples):/mnt/samples mquery_tests | |||
- name: get run logs | |||
if: always() | |||
run: docker-compose logs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This wasn't just used for debugging and we're leaving this in, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should've been a separate PR... But yeah, this is very much intended to stay. Without this, docker-compose logs are not available in the CI when something crashes.
eb492df
to
4088b29
Compare
Resolved discussions, squashed... Just realised that I should make it possible (or document) to configure mquery with a config-file even when docker-compose is used. Not sure how to do this correctly, will handle this tomorrow. Edit: actually docker users should configure their instance with environment vars or mount the config themselves, so that's not applicable. |
Your checklist for this pull request
This is a WIP draft PR for migration of mquery's config from current config mechanism (config.py) to typed-config.
It doesn't take configuration from redis to the config file yet. It's backwards compatible for docker and kubernetes users (i.e. ENV config didn't change). Despite this, it's still technically backward incompatible for users who use bare metal mquery and edited their config.py
Fixes #320
Fixes #318
Fixes #261