Add a configurable about page #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msm-code
force-pushed
the
feature/about-page
branch
from
567a376
to
08cf046
Compare
msm-code
changed the title
|
Rebased onto typed config. Ready for review. |
msm-code
commented
Jan 24, 2023
| > | ||
| <span className="navbar-toggler-icon" /> | ||
| </button> | ||
| <div className="container-fluid"> |
There was a problem hiding this comment.
This is a bit unrelated to the current PR - new bootstrap requires navbar contents to be contained within a conteiner-fluid div
nazywam
approved these changes
Jan 25, 2023
| @@ -130,3 +130,4 @@ class ServerSchema(BaseModel): | |||
| auth_enabled: Optional[str] | |||
| openid_url: Optional[str] | |||
| openid_client_id: Optional[str] | |||
| about: str | |||
There was a problem hiding this comment.
This will be populated with the default value "" if not present in the database, right?
There was a problem hiding this comment.
Yes. Originally this was Optional[str] in the schema too, but I realised this will never actually be null.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
What is the current behaviour?
There is no way to add any customised information for the users #323
What is the new behaviour?
This PR adds (will add) a customisable "about" page. It's not very customisable, because all the information will have to fit into a config file, but that should be enough to give users a few URLs or explain what's going on.
This subpage is optional (will be optional in the final PR).
I've decided to allow HTML (it's trusted - it comes from the server) instead of just plain text.
Test plan
Visit /about.
Closing issues
fixes #323