Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the /about route #343

Merged
merged 1 commit into from Jan 26, 2023
Merged

Conversation

msm-code
Copy link
Contributor

Your checklist for this pull request

  • I've read the contributing guideline.
  • I've tested my changes by building and running mquery, and testing changed functionality (if applicable)
  • I've added automated tests for my change (if applicable, optional)
  • I've updated documentation to reflect my change (if applicable)

What is the current behaviour?
Users can't visit /about route directly. It's handled by react on the client side, but server responds 404 to it. We already made this mistake before.

What is the new behaviour?
going to /about route directly works

Test plan
Visit /about.

Closing issues

@msm-code msm-code requested a review from nazywam January 25, 2023 23:12
@msm-code msm-code merged commit 6ca10a3 into CERT-Polska:master Jan 26, 2023
@msm-code msm-code deleted the fix/about-path branch January 26, 2023 17:03
@msm-code msm-code mentioned this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants