Fix: Too eager schema for FileItemResponseSchema.latest_config field (#…

…942)
CERT-Polska · Jun 8, 2024 · 10982df · 10982df
1 parent 20b40b9
commit 10982df
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/mwdb/schema/config.py b/mwdb/schema/config.py
@@ -41,6 +41,19 @@ class ConfigListResponseSchema(
     __envelope_key__ = "configs"
 
 
+class ConfigLatestItemResponseSchema(ObjectListItemResponseSchema):
+    """
+    Limited ConfigItemResponseSchema that doesn't fetch relationships
+    and other extra metadata.
+
+    Used by FileItemResponseSchema.latest_config field.
+    """
+
+    family = fields.Str(required=True, allow_none=False)
+    config_type = fields.Str(required=True, allow_none=False)
+    cfg = fields.Dict(required=True, allow_none=False)
+
+
 class ConfigItemResponseSchema(ObjectItemResponseSchema):
     family = fields.Str(required=True, allow_none=False)
     config_type = fields.Str(required=True, allow_none=False)

diff --git a/mwdb/schema/file.py b/mwdb/schema/file.py
@@ -2,7 +2,7 @@
 
 from marshmallow import Schema, fields, pre_load
 
-from .config import ConfigItemResponseSchema
+from .config import ConfigLatestItemResponseSchema
 from .object import (
     ObjectCreateRequestSchemaBase,
     ObjectItemResponseSchema,
@@ -67,7 +67,7 @@ class FileItemResponseSchema(ObjectItemResponseSchema):
     ssdeep = fields.Str(required=True, allow_none=True)
 
     latest_config = fields.Nested(
-        ConfigItemResponseSchema, required=True, allow_none=True
+        ConfigLatestItemResponseSchema, required=True, allow_none=True
     )