Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisited share endpoints #105

Merged
merged 2 commits into from
Jul 27, 2020
Merged

Revisited share endpoints #105

merged 2 commits into from
Jul 27, 2020

Conversation

psrok1
Copy link
Member

@psrok1 psrok1 commented Jul 27, 2020

Your checklist for this pull request

  • I've read the contributing guideline.
  • I've tested my changes by building and running the project, and testing changed functionality (if applicable)
  • I've updated documentation to reflect my change (if applicable)

What changed?

  • PUT /{type}/{identifier}/share returns shares including change instead of empty response
  • Refactored schema to follow the convention
  • Added Object.get_shares() method

Test plan

  • All changes should be already covered by automated tests
  • Tested sharing using mwdblib and web

@psrok1 psrok1 mentioned this pull request Jul 27, 2020
Closed
16 tasks
@psrok1 psrok1 added this to the 2.0.0-alpha2 milestone Jul 27, 2020
@psrok1 psrok1 merged commit d810ecb into master Jul 27, 2020
@psrok1 psrok1 deleted the refactor/share-endpoints branch July 27, 2020 14:32
@psrok1 psrok1 linked an issue Jul 27, 2020 that may be closed by this pull request
Backend API code and documentation refactor #75
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nazywam nazywam nazywam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0-alpha2
Development

Successfully merging this pull request may close these issues.

Backend API code and documentation refactor
2 participants
@psrok1 @nazywam