-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
human-readable file size frontend support #233
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Frontend part looks ok , but search/fields.py
needs to be simplified
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok 👍
Guys please attach screenshots to the PRs, it will be very helpful to easily see the new feature without reading the code :) |
For some reason I have missed your comment. |
you rock! ♥ |
Your checklist for this pull request
What is the current behaviour?
File sizes are only shown as bytes.
What is the new behaviour?
File sizes are only shown in human-readable form.
Test plan
Check if human-readable file size form match with the original in bytes.
Closing issues
closes #229