Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Enter key behavior in Autocomplete list #408

Merged
merged 2 commits into from
Jun 22, 2021
Merged

Conversation

psrok1
Copy link
Member

@psrok1 psrok1 commented Jun 21, 2021

Your checklist for this pull request

  • I've read the contributing guideline.
  • I've tested my changes by building and running the project, and testing changed functionality (if applicable)
  • I've added automated tests for my change (if applicable, optional)
  • I've updated documentation to reflect my change (if applicable)

What is the current behaviour?

Dropdown menu buttons have not correct type. Default button type is submit, so they take over Enter key handling after dropdown appear.

What is the new behaviour?

Added type="button" to dropdown menu buttons, so input is correctly submitted.

Closing issues

closes #401

@psrok1 psrok1 requested a review from KWMORALE June 21, 2021 17:18
Copy link
Member

@KWMORALE KWMORALE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now works fine

@psrok1 psrok1 merged commit 3f41852 into master Jun 22, 2021
@psrok1 psrok1 deleted the fix/autocomplete-enter branch June 22, 2021 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enter key doesn't work when item was chosen from autocomplete list
2 participants