Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/delete karton analyze object association #533

Merged
merged 10 commits into from
Mar 8, 2022

Conversation

wklimek
Copy link
Contributor

@wklimek wklimek commented Feb 9, 2022

Your checklist for this pull request

  • I've read the contributing guideline.
  • I've tested my changes by building and running the project, and testing changed functionality (if applicable)
  • I've added automated tests for my change (if applicable, optional)
  • I've updated documentation to reflect my change (if applicable)

What is the current behaviour?

There is no endpoint to remove analysis from object.
What is the new behaviour?

Endpoint DELETE /api/<any(file, config, blob, object):type>/hash64:identifier/karton/<analysis_id> was added.
Frondend feature to call new endpoint and remove analysis from object was added.
Bug - possibility to remove comment which is not associated with object - was fixed.
Test plan

Closing issues

closes #issuenumber

@wklimek wklimek requested review from psrok1 and removed request for psrok1 February 16, 2022 08:30
@wklimek wklimek marked this pull request as ready for review February 16, 2022 08:32
@wklimek wklimek requested a review from psrok1 February 16, 2022 08:32
@wklimek wklimek marked this pull request as draft February 18, 2022 11:15
@wklimek wklimek removed the request for review from psrok1 February 18, 2022 11:16
@wklimek wklimek marked this pull request as ready for review February 22, 2022 11:26
@wklimek wklimek requested a review from psrok1 February 22, 2022 11:26
Copy link
Member

@psrok1 psrok1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied few fixes on my own:

  • removing_karton renamed to karton_unassign to have more similar name
  • changed db_comment in db_object.comments to Comment.object_id == db_object.id filter. Similar approach is used in other places.

For changelog information, this PR applies additional fixes:

  • Comment identifier was not associated with object during deletion operation, so effectively object access was not properly checked.
  • Missing Capabilities.personalize requirement in Unmark favorite object operation.

@psrok1 psrok1 merged commit 504ad2f into master Mar 8, 2022
@psrok1 psrok1 deleted the feature/delete-karton-analyze-object-association branch March 8, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants