-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/delete karton analyze object association #533
Merged
psrok1
merged 10 commits into
master
from
feature/delete-karton-analyze-object-association
Mar 8, 2022
Merged
Feature/delete karton analyze object association #533
psrok1
merged 10 commits into
master
from
feature/delete-karton-analyze-object-association
Mar 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thub.com:CERT-Polska/mwdb-core into feature/delete-karton-analyze-object-association
psrok1
approved these changes
Mar 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied few fixes on my own:
removing_karton
renamed tokarton_unassign
to have more similar name- changed
db_comment in db_object.comments
toComment.object_id == db_object.id
filter. Similar approach is used in other places.
For changelog information, this PR applies additional fixes:
- Comment identifier was not associated with object during deletion operation, so effectively object access was not properly checked.
- Missing
Capabilities.personalize
requirement inUnmark favorite object
operation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
What is the current behaviour?
There is no endpoint to remove analysis from object.
What is the new behaviour?
Endpoint DELETE /api/<any(file, config, blob, object):type>/hash64:identifier/karton/<analysis_id> was added.
Frondend feature to call new endpoint and remove analysis from object was added.
Bug - possibility to remove comment which is not associated with object - was fixed.
Test plan
Closing issues
closes #issuenumber