Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: replace Flask-Restful with own, simple implementation #916

Merged
merged 5 commits into from Feb 27, 2024

Conversation

psrok1
Copy link
Member

@psrok1 psrok1 commented Feb 21, 2024

Your checklist for this pull request

  • I've read the contributing guideline.
  • I've tested my changes by building and running the project, and testing changed functionality (if applicable)
  • I've added automated tests for my change (if applicable, optional)
  • I've updated documentation to reflect my change (if applicable)

What is the current behaviour?

  • Flask-Restful is not really maintained right now and hard-pins us to specific Flask versions
  • before_request and after_request callbacks meant for API blueprint are also applied to static blueprint

What is the new behaviour?

  • We use our own MethodView-based wrapper
  • Bumped apispec, marshmallow and Flask

@psrok1 psrok1 force-pushed the refactor/replace-flask-restful branch 2 times, most recently from 6f3026d to 6fa4f71 Compare February 26, 2024 15:46
@psrok1 psrok1 marked this pull request as ready for review February 26, 2024 16:37
@psrok1 psrok1 force-pushed the refactor/replace-flask-restful branch from 6ff9439 to 1ccffdc Compare February 27, 2024 12:03
@psrok1 psrok1 merged commit 3b11349 into master Feb 27, 2024
12 checks passed
@psrok1 psrok1 deleted the refactor/replace-flask-restful branch February 27, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant