Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Don't treat 0 number as an empty attribute value #920

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

psrok1
Copy link
Member

@psrok1 psrok1 commented Feb 23, 2024

Your checklist for this pull request

  • I've read the contributing guideline.
  • I've tested my changes by building and running the project, and testing changed functionality (if applicable)
  • I've added automated tests for my change (if applicable, optional)
  • I've updated documentation to reflect my change (if applicable)

What is the current behaviour?

Mentioned in #907, if we try to set 0 value in JSON/object mode, we get ValidationError as value is considered empty

What is the new behaviour?

The only empty values are "", {}, [], null

Test plan

Covered by automated test

Closing issues

@psrok1 psrok1 marked this pull request as ready for review February 23, 2024 18:17
@psrok1 psrok1 requested a review from msm-cert February 23, 2024 18:18
@psrok1 psrok1 merged commit 9e97428 into master Feb 26, 2024
12 checks passed
@psrok1 psrok1 deleted the fix/falsy-value-validation branch February 26, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant