Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

Update Linux INSTALL file #11

Merged
merged 2 commits into from Nov 18, 2016
Merged

Conversation

gwasser
Copy link
Contributor

@gwasser gwasser commented Nov 17, 2016

Made following changes:

  • valgrind was listed as a dependency later in the file, but missing from the beginning list
  • specifically pointed out that Python 3 is not currently supported
  • new instructions added for the latest openSUSE release (openSUSE Leap 42.2)

@wdormann
Copy link

Is Python3 support being worked on?
Is the CERT-patched zzuf mandatory, as opposed to the standard zzuf version?

Your change implies that both statements are true, and I'm not sure that's the case.

@gwasser
Copy link
Contributor Author

gwasser commented Nov 18, 2016

I'm working on Python3 support (I like Py3). :-)

I can remove the comment about zzuf. It looks like the BFF 2.8 download includes zzuf-master implying its just a checkout of the upstream code. Was the patch submitted upstream?

@wdormann
Copy link

Ah, good catch. It looks like the recent UbuFuzz builds call the zip "zzuf-master.zip" instead of "zzuf-patched.zip". I guess the INSTALL file should also be updated to reflect this.

The patch should be in ~/in/zzuf/zzuf_patch.diff
The upsteam zzuf project didn't accept all of our changes the first time around, so we moved on with the assumption that we'd just use a zzuf fork.

The CERT version of zzuf has some optimizations and improvement, but the stock zzuf should also work.

@gwasser
Copy link
Contributor Author

gwasser commented Nov 18, 2016

The BFF 2.8 scripts zip file available at https://www.cert.org/vulnerability-analysis/tools/bff-download.cfm has a zzuf-master.zip file. Unpacking it, there's no zzuf_patch.diff file included (I grepped for it). Was the wrong archive included? This version of zzuf still works fine though so proves that upstream works if so.

@wdormann
Copy link

zzuff_patch.diff comes with UbuFuzz. I've explicitly added this to the BFF code in 52e7b97.

The problem with the released zzuf-master.zip is that it wasn't called zzuf-patched.zip. But it is indeed the patched version. One easy way to tell is if it includes the "null" opmode.

Copy link
Contributor

@ahouseholder ahouseholder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahouseholder ahouseholder merged commit 880a916 into CERTCC:develop Nov 18, 2016
@gwasser gwasser deleted the readme_update branch November 21, 2016 23:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants