Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libtrap: bugfix in TCPIP interface #99

Merged
merged 1 commit into from
Aug 26, 2018
Merged

Conversation

janskto1
Copy link
Contributor

After a socket was closed because of unsuccessful negotiation,
it was not set to -1. This caused other functions to treat the socket as valid.
Such bahevior resulted in situation where this socket was passed to select() function.
Select() function returns EBADF when a bad file descriptor is passed.
Further fucntions subsequently segfaulted.

After a socket was closed because of unsuccessful negotiation,
it was not set to -1. This caused other functions to treat the socket as valid.
Such bahevior resulted in situation where this socket was passed to select() function.
Select() function returns EBADF when a bad file descriptor is passed.
Further fucntions subsequently segfaulted.
@janskto1 janskto1 requested a review from cejkato2 August 26, 2018 12:38
@codecov-io
Copy link

codecov-io commented Aug 26, 2018

Codecov Report

Merging #99 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
- Coverage   50.79%   50.78%   -0.02%     
==========================================
  Files          50       50              
  Lines       10231    10232       +1     
==========================================
- Hits         5197     5196       -1     
- Misses       5034     5036       +2
Impacted Files Coverage Δ
libtrap/src/ifc_tcpip.c 61.06% <0%> (-0.08%) ⬇️
libtrap/src/trap.c 46.02% <0%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 476073f...64b73dc. Read the comment docs.

@cejkato2 cejkato2 merged commit 4a95b94 into master Aug 26, 2018
@cejkato2 cejkato2 deleted the hotfix_libtrap_segfault branch August 26, 2018 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants