client session BUGFIX check all errors when creating RPCs

Fixes #283
CESNET · Jan 13, 2021 · 283c3c0 · 283c3c0
1 parent 623d59e
commit 283c3c0
Showing 1 changed file with 15 additions and 3 deletions.
diff --git a/src/session_client.c b/src/session_client.c
@@ -2654,20 +2654,32 @@ nc_send_rpc(struct nc_session *session, struct nc_rpc *rpc, int timeout, uint64_
 
         data = lyd_new(NULL, mod, "kill-session");
         sprintf(str, "%u", rpc_k->sid);
-        lyd_new_leaf(data, mod, "session-id", str);
+        node = lyd_new_leaf(data, mod, "session-id", str);
+        if (!node) {
+            lyd_free(data);
+            return NC_MSG_ERROR;
+        }
         break;
 
     case NC_RPC_COMMIT:
         rpc_com = (struct nc_rpc_commit *)rpc;
 
         data = lyd_new(NULL, mod, "commit");
         if (rpc_com->confirmed) {
-            lyd_new_leaf(data, mod, "confirmed", NULL);
+            node = lyd_new_leaf(data, mod, "confirmed", NULL);
+            if (!node) {
+                lyd_free(data);
+                return NC_MSG_ERROR;
+            }
         }
 
         if (rpc_com->confirm_timeout) {
             sprintf(str, "%u", rpc_com->confirm_timeout);
-            lyd_new_leaf(data, mod, "confirm-timeout", str);
+            node = lyd_new_leaf(data, mod, "confirm-timeout", str);
+            if (!node) {
+                lyd_free(data);
+                return NC_MSG_ERROR;
+            }
         }
 
         if (rpc_com->persist) {