compat: fix pthread_mutex_timedlock
#424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code looked a bit fishy: - There's no need to check up front whether we're dividing a zero or non-zero number by some constant. - The conversion to milliseconds is actually not needed at all because it gets immediately converted to back to nanoseconds.
michalvasko
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compat: return
ETIMEDOUTwhen timing outrefactor: compat: simplify waiting
This code looked a bit fishy:
There's no need to check up front whether we're dividing a zero or non-zero number by some constant.
The conversion to milliseconds is actually not needed at all because it gets immediately converted to back to nanoseconds.