Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right utility buttons don't work properly on iOS 8 #237

Closed
hongrich opened this issue Sep 11, 2014 · 10 comments · Fixed by #238
Closed

Right utility buttons don't work properly on iOS 8 #237

hongrich opened this issue Sep 11, 2014 · 10 comments · Fixed by #238

Comments

@hongrich
Copy link
Contributor

On iOS 8, the right utility buttons don't seem to be working properly. Using the sample project with a minor change, setting useCustomCells to YES in viewDidLoad, the left utility buttons opens correctly but the right utility buttons do not.

Here's a little movie of me doing this:
https://dl.dropboxusercontent.com/u/30096/SWTableViewCell_iOS8_with_left_buttons.mov

Interestingly, after I tap and hold on the cell, swiping to show the right buttons work again.

If I disable the left buttons, the swiping doesn't work at all until I tap and hold.

https://dl.dropboxusercontent.com/u/30096/SWTableViewCell_iOS8_without_left_buttons.mov

This only happens on iOS 8 and not iOS 7.

@sradu
Copy link

sradu commented Sep 12, 2014

+1 same thing

@nchatharoo
Copy link

+1

@joecarey81
Copy link

I have a similar problem, but I can only see the right buttons if the cells is dequeued again...by scrolling or going to another view and then coming back to my table view...

@bkmu
Copy link

bkmu commented Sep 12, 2014

@joecarey81 I was having the same issues as you and have come to the same conclusion. For the benefit of all, while I don't yet have a fix I did discover going back to the pre-iOS6

-dequeueReusableCellWithIdentifier:

Instead of

-dequeueReusableCellWithIdentifier:forIndexPath:

Resulted in the rightButtons working at initial load. I'm probably going to dive into the guts of SWTableViewCell after dinner with fresh eyes to figure out the differences between these two dequeue mechanisms and how they'd wind up negatively influencing the scroll view (unless someone beats me to it!) as I'd like to use more modern API whenever possible.

@hongrich
Copy link
Contributor Author

@bmusial do you mind trying #238 and see if that fixes this problem for you?

@bkmu
Copy link

bkmu commented Sep 12, 2014

@hongrich -- I'll do that now before I head out. Back in a few.

@bkmu
Copy link

bkmu commented Sep 12, 2014

@hongrich Success! I did some additional testing: Those 4 lines work for me with the stock -dequeueReusableCellWithIdentifier:forIndexPath: call for both compilation against the iOS 7.1 SDK on devices running iOS 7 and iOS 8 as well as compilation against iOS 8 SDK on devices running iOS 7 and IOS 8.

@hongrich
Copy link
Contributor Author

Awesome. Glad it worked for you too.

@CEWendel
Copy link
Owner

Cool I will merge that in when I get home. Thanks guys

Sent from my iPhone

On Sep 12, 2014, at 7:03 PM, Rich Hong notifications@github.com wrote:

Awesome. Glad it worked for you too.


Reply to this email directly or view it on GitHub.

@bkmu
Copy link

bkmu commented Sep 12, 2014

++ Thanks all!

CEWendel added a commit that referenced this issue Sep 16, 2014
Fixes #237, Right utility buttons don't work properly on iOS 8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants