Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[draft] support multiple named dimensions using similar discretizations of the same continuous dimension #71

Closed
wants to merge 1 commit into from

Conversation

jbigot
Copy link
Member

@jbigot jbigot commented Jul 6, 2022

No description provided.

@tpadioleau
Copy link
Member

@jbigot tell me when to review it.

@jbigot
Copy link
Member Author

jbigot commented Jul 7, 2022

It's not ready yet, I mostly wanted the tests to run. I forgot to mark it as draft and don't see a way to change it after the fact

@jbigot jbigot changed the title support multiple named dimensions using similar discretizations of the same continuous dimension [draft] support multiple named dimensions using similar discretizations of the same continuous dimension Jul 7, 2022
@jbigot jbigot marked this pull request as draft July 7, 2022 15:41
@jbigot
Copy link
Member Author

jbigot commented Jul 7, 2022

ok, found it

@tpadioleau
Copy link
Member

I renamed IDim -> DDim in the main branch.

@tpadioleau
Copy link
Member

choosing #121

@tpadioleau tpadioleau closed this Jun 15, 2023
@jbigot jbigot deleted the named_dim branch June 21, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants