Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a very nice d3q27 viscoplastic model. Two example xml-scripts a… #102

Merged
merged 2 commits into from
Dec 2, 2016

Conversation

voytekr
Copy link
Contributor

@voytekr voytekr commented Sep 28, 2016

added d3q27_viscoplastic model. Please test it, two test scripts are available. Enjoy!

AddNodeType("CoutVelocity","BOUNDARY")
AddNodeType("PCoutVelocity","BOUNDARY")
AddNodeType("WVelocityEq","BOUNDARY")
AddNodeType("WVelocityBB","BOUNDARY")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change BC names.
[N/S/W/E/I/O]Velocity_CleverVariant would be proper way
If you use In/Out (z direction) BC's, check naming with newest cumulant form Dmitro

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applies to lines 36 to 49 ;]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, there are no options for "WVelocityEq" and "WVelocityBB" -will be removed. Naming convention will be followed

AddSetting(name="ForceX",default=0, comment='Force force X')
AddSetting(name="ForceY",default=0, comment='Force force Y')
AddSetting(name="ForceZ",default=0, comment='Force force Z')
AddSetting(name="SigmaY",default=0, comment='Yield stress')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit?

AddDensity(name="nu_app", dx=0, dy=0, dz=0)
AddDensity(name="yield_stat", dx=0, dy=0, dz=0)

AddSetting(name="GalileanCorrection",default=1.,comment='Galilean correction term')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused. Will be removed.

AddQuantity( name="P",unit="Pa")
AddQuantity( name="U",unit="m/s",vector=T)
AddQuantity( name="nu_app",unit="m2/s")
AddQuantity( name="yield_stat")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to speficy "empty" or "-" unit? yield_stat shows if the region is yielded or not (value 0 or 1)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then don't specify any, its OK. And maybe add comment to future generations :]

AddGlobal(name="YZrho2", comment='Volume flux', unit="kg/m")
AddGlobal(name="YZarea", comment='Volume flux', unit="m2")

#Adding terms for supporting time-correlation for synthetic turbulence
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed comment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

AddGlobal(name="YZvz", comment='Volume flux', unit="m3/s")
AddGlobal(name="YZrho1", comment='Volume flux', unit="kg/m")
AddGlobal(name="YZrho2", comment='Volume flux', unit="kg/m")
AddGlobal(name="YZarea", comment='Volume flux', unit="m2")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you use/intend to implement all those globals and nodetypes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I do. Very often when I run simulations I have to integrate fluxes along principal directions

1. naming convention as suggested by mdzik
2. removed SymmetryBottom and symmetryTop - thay act as SymmetryY - no need to distinguish that
3. units added at some quantities
4. two test ".xml" files modified adequately to follow the namig convention
AddNodeType("NPressure_ZouHe", "BOUNDARY")
AddNodeType("SPressure_ZouHe", "BOUNDARY")
AddNodeType("EPressure_ZouHe", "BOUNDARY")
AddNodeType("WPressure_ZouHe", "BOUNDARY")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, my fault:
ZouHe is "default" way to handle BC's, so no need for suffix. Use suffix only if you have different "variants" of bc, like:
EVelocity (standard one)
EVelocity_ViscosityCorrection
EVelocity_ConstantFlux
EVelocity_Kowalski
or something like that

once again, sorry for double work. (I was reffering rather to PCoutVelocity)

@llaniewski
Copy link
Member

I'm merging, as I think the model is more or less ready - and I'm planning a code cleanup soon.

@llaniewski llaniewski merged commit c8b0bf3 into CFD-GO:develop Dec 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants