Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing missing file paths #97

Merged
merged 7 commits into from
Aug 4, 2016
Merged

Conversation

llaniewski
Copy link
Member

Fixed missing paths for many of the optimization related files. They we're placed in the main directory always, which caused many problems for running several cases in the same directory.

plus some small fixes for TXT and sw graphic display.

@llaniewski
Copy link
Member Author

@mdzik Can you check what is wrong with the testing? I'll be leaving for some time and don't have time to check. When I compile on CPU at my computer, the tests do not fail.

@mdzik
Copy link
Member

mdzik commented Aug 3, 2016

Hmm, signal 11, know as "segmentation fault".
I have docker with TravisCI images up&singing, so will do

@llaniewski
Copy link
Member Author

@mdzik Ok. I found it. I missed one constructor.

@mdzik
Copy link
Member

mdzik commented Aug 4, 2016

God dam it, those missing constructors ;p
BTW: valgrind didn't blow on that, while plain run segfaulted. I really love that tool :/

Maybe we want to include valgrind cpu run to tests? That is simple to implement, but will hurt our feelings.

I've checked how current develop is doing in karman test. We have some memleaks, a lot of "new dim".
Cons: Travis test will take much longer

@llaniewski
Copy link
Member Author

Yeah, I'm still considering Valgrind on Travis-CI, but to fix all the leaks would be very hard. This is post-PhD :D

@llaniewski llaniewski merged commit 6fd4c59 into CFD-GO:develop Aug 4, 2016
@llaniewski llaniewski deleted the spline_param branch October 29, 2019 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants