-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Masking fix in cosp_diag_warmrain? #63
Comments
The wrinkle to this is cloud-free scenes and dark scenes are both set to R_UNDEF in the modis-simulator. We want to include to former, but not the latter. |
@dustinswales I apporogize for this bug and late reply. The warm rain diagnostics did intend to use only daytime cloudy scenes, but actually the current code did not explicitly exclude dark-scene columns from the analysis. https://github.com/CFMIP/COSPv2.0/blob/master/src/cosp_stats.F90#L338
https://github.com/CFMIP/COSPv2.0/blob/master/src/cosp_stats.F90#L345
I think this change will work appropriately for the issue. I push the bug-fix later via pull request. |
@dustinswales I think that we can now close this thread, as we have corrected this bug in the recent PR (#73). Thank you for your support. |
@takmichibata |
cosp_diag_warmrain relies on the MODIS LWP(IWP)'s to determine when to perform a retrieval, https://github.com/CFMIP/COSPv2.0/blob/master/src/cosp_stats.F90#L345
However, the MODIS LWP is set to R_UNDEF, -999, for non-sunlit points prior to this routine being called. In these cases, zeros are being assigned for some of the diagnostics, where they should be set to R_UNDEF and omitted for the statistics.
This came up in an unrelated PR from 2019 (#36).
The text was updated successfully, but these errors were encountered: