Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amethyst Tools Mod 翻译提交 #3055

Merged
merged 13 commits into from
Mar 27, 2023
Merged

Amethyst Tools Mod 翻译提交 #3055

merged 13 commits into from
Mar 27, 2023

Conversation

Gjg5
Copy link
Contributor

@Gjg5 Gjg5 commented Feb 19, 2023

  • 我已仔细阅读贡献指南 CONTRIBUTING；
  • 我已确认英文原文（如 en_us.json）存在且完整，内容与中文对应；
  • 我已阅读并同意按 CC BY-NC-SA 4.0 协议发布我的作品；
  • 刷新 PR 的标签/状态，有需要再点击；

@boring-cyborg boring-cyborg bot added 1.19.x Forge include Forge mod labels Feb 19, 2023
@cfpa-bot
Copy link
Contributor

cfpa-bot bot commented Feb 19, 2023 •
edited
Loading

⚠ 更新模组列表出错: Exception of type 'System.ArgumentOutOfRangeException' was thrown. (Parameter 'version')
Actual value was 1.19.

💾 基于此 PR 所打包的资源包：

⚠ 检查出错: Exception of type 'System.ArgumentOutOfRangeException' was thrown. (Parameter 'version')
Actual value was 1.19.

  • 🔄 勾选这个复选框来强制刷新

@cfpa-bot cfpa-bot bot added the 100+ Size label. label Feb 19, 2023
mamaruo
mamaruo requested changes Feb 19, 2023
View reviewed changes
Copy link
Member

@mamaruo mamaruo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请务必熟悉原版译名再翻译，如铲子、裤子、缓落，药水箭的格式

CONTRIBUTING 里明确规定了标题格式，请遵守！

我已仔细阅读贡献指南 CONTRIBUTING；

@Gjg5 Gjg5 requested a review from mamaruo February 19, 2023 05:33
Ricky-fight
Ricky-fight requested changes Feb 19, 2023
View reviewed changes
Copy link
Collaborator

@Ricky-fight Ricky-fight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

～32

请完整阅读一遍原版译名以及贡献指南

projects/1.19/assets/amethysttoolsmod-/amethyst-tools-mod/lang/zh_cn.json Outdated Show resolved Hide resolved
projects/1.19/assets/amethysttoolsmod-/amethyst-tools-mod/lang/zh_cn.json Outdated Show resolved Hide resolved
projects/1.19/assets/amethysttoolsmod-/amethyst-tools-mod/lang/zh_cn.json Outdated Show resolved Hide resolved
projects/1.19/assets/amethysttoolsmod-/amethyst-tools-mod/lang/zh_cn.json Outdated Show resolved Hide resolved
projects/1.19/assets/amethysttoolsmod-/amethyst-tools-mod/lang/zh_cn.json Outdated Show resolved Hide resolved
projects/1.19/assets/amethysttoolsmod-/amethyst-tools-mod/lang/zh_cn.json Outdated Show resolved Hide resolved
projects/1.19/assets/amethysttoolsmod-/amethyst-tools-mod/lang/zh_cn.json Outdated Show resolved Hide resolved
projects/1.19/assets/amethysttoolsmod-/amethyst-tools-mod/lang/zh_cn.json Outdated Show resolved Hide resolved
projects/1.19/assets/amethysttoolsmod-/amethyst-tools-mod/lang/zh_cn.json Outdated Show resolved Hide resolved
@mamaruo
Copy link
Member

mamaruo commented Feb 19, 2023 •
edited
Loading

@Ricky-fight 网页 review 的 suggestion 填充会自动整出一个空行，如果说用户使用 commit suggestion 的话就灾难了

@Gjg5
一字一句地读：模组简体中文翻译规范与指南

mamaruo
mamaruo requested changes Feb 19, 2023
View reviewed changes
Copy link
Member

@mamaruo mamaruo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还有标题！药水箭的格式XX之箭，我之前都提到了……………………

projects/1.19/assets/amethysttoolsmod-/amethyst-tools-mod/lang/zh_cn.json Outdated Show resolved Hide resolved
projects/1.19/assets/amethysttoolsmod-/amethyst-tools-mod/lang/zh_cn.json Outdated Show resolved Hide resolved
@Ricky-fight
Copy link
Collaborator

@Ricky-fight 网页 review 的 suggestion 填充会自动整出一个空行，如果说用户使用 commit suggestion 的话就灾难了

@Gjg5 一字一句地读：模组简体中文翻译规范与指南

甚至iOS上review根本看不出有没有多空行（）

@mamaruo mamaruo changed the title Amethyst-tools Amethyst Tools Mod 翻译提交 Feb 25, 2023
@mamaruo
Copy link
Member

mamaruo commented Feb 25, 2023

/mv projects/1.19/assets/amethysttoolsmod-/amethyst-tools-mod/lang/en_us.json projects/1.19/assets/amethyst-tools-mod/amethysttoolsmod/lang/en_us.json
/mv projects/1.19/assets/amethysttoolsmod-/amethyst-tools-mod/lang/zh_cn.json projects/1.19/assets/amethyst-tools-mod/amethysttoolsmod/lang/zh_cn.json

cfpa-bot bot and others added 3 commits February 26, 2023 02:28
@cfpa-bot @mamaruo
mv projects/1.19/assets/amethysttoolsmod-/amethyst-tools-mod/lang/en_…
20883b6 
…us.json projects/1.19/assets/amethyst-tools-mod/amethysttoolsmod/lang/en_us.json

Co-authored-by: mamaruo <37480168+mamaruo@users.noreply.github.com>
@cfpa-bot @mamaruo
mv projects/1.19/assets/amethysttoolsmod-/amethyst-tools-mod/lang/zh_…
57c1c52 
…cn.json projects/1.19/assets/amethyst-tools-mod/amethysttoolsmod/lang/zh_cn.json

Co-authored-by: mamaruo <37480168+mamaruo@users.noreply.github.com>
@Gjg5
修改
ce5281f
Ricky-fight
Ricky-fight requested changes Mar 8, 2023
View reviewed changes
projects/1.19/assets/amethyst-tools-mod/amethysttoolsmod/lang/zh_cn.json Outdated Show resolved Hide resolved
projects/1.19/assets/amethyst-tools-mod/amethysttoolsmod/lang/zh_cn.json Outdated Show resolved Hide resolved
projects/1.19/assets/amethyst-tools-mod/amethysttoolsmod/lang/zh_cn.json Outdated Show resolved Hide resolved
projects/1.19/assets/amethyst-tools-mod/amethysttoolsmod/lang/zh_cn.json Outdated Show resolved Hide resolved
projects/1.19/assets/amethyst-tools-mod/amethysttoolsmod/lang/zh_cn.json Outdated Show resolved Hide resolved
projects/1.19/assets/amethyst-tools-mod/amethysttoolsmod/lang/zh_cn.json Outdated Show resolved Hide resolved
projects/1.19/assets/amethyst-tools-mod/amethysttoolsmod/lang/zh_cn.json Outdated Show resolved Hide resolved
projects/1.19/assets/amethyst-tools-mod/amethysttoolsmod/lang/zh_cn.json Outdated Show resolved Hide resolved
@ChuijkYahus ChuijkYahus added 即将拒收 在此标签被添加的 24 小时后 Pull Request 才可被关闭 and removed 即将拒收 在此标签被添加的 24 小时后 Pull Request 才可被关闭 labels Mar 26, 2023
ChuijkYahus
ChuijkYahus requested changes Mar 26, 2023
View reviewed changes
projects/1.19/assets/amethyst-tools-mod/amethysttoolsmod/lang/zh_cn.json Outdated Show resolved Hide resolved
projects/1.19/assets/amethyst-tools-mod/amethysttoolsmod/lang/zh_cn.json Outdated Show resolved Hide resolved
projects/1.19/assets/amethyst-tools-mod/amethysttoolsmod/lang/zh_cn.json Outdated Show resolved Hide resolved
projects/1.19/assets/amethyst-tools-mod/amethysttoolsmod/lang/zh_cn.json Outdated Show resolved Hide resolved
projects/1.19/assets/amethyst-tools-mod/amethysttoolsmod/lang/zh_cn.json Outdated Show resolved Hide resolved
projects/1.19/assets/amethyst-tools-mod/amethysttoolsmod/lang/zh_cn.json Outdated Show resolved Hide resolved
projects/1.19/assets/amethyst-tools-mod/amethysttoolsmod/lang/zh_cn.json Outdated Show resolved Hide resolved
@ChuijkYahus ChuijkYahus added the 即将合并 在此标签被添加的 24 小时后 Pull Request 才可被合并 label Mar 26, 2023
@ChuijkYahus ChuijkYahus merged commit c8e8c74 into CFPAOrg:main Mar 27, 2023
@ChuijkYahus ChuijkYahus mentioned this pull request Mar 31, 2023
Closed
4 tasks
@DrIceTea123 DrIceTea123 mentioned this pull request Jul 23, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luoxueyasha luoxueyasha luoxueyasha left review comments

@Ricky-fight Ricky-fight Ricky-fight requested changes

@mamaruo mamaruo mamaruo requested changes

@ChuijkYahus ChuijkYahus ChuijkYahus approved these changes

Assignees
No one assigned
Labels
1.19.x 100+ Size label. Forge include Forge mod 即将合并 在此标签被添加的 24 小时后 Pull Request 才可被合并
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Gjg5 @mamaruo @Ricky-fight @luoxueyasha @ChuijkYahus