New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add basic CompletionItemKind #9

Merged

CFiggers merged 3 commits into CFiggers:master from fnurk:feat/binding-types-in-completion

Nov 10, 2023

Contributor

fnurk commented Nov 9, 2023

This is tested in nvim, see screenshot below. NB minimal/partial implementation.


          feat: add basic CompletionItemKind

8620d73

Owner

CFiggers commented Nov 9, 2023

This is a great idea. Thanks for the PR.

We should probably handle all of the types that could come up, since this will also reflect user-defined bindings—in particular you're missing:

:keyword
:table
:struct
:array
:tuple
:buffer
:boolean
:nil
:fiber
:core/file

And technically there are some other core/${foo} types, but those are rare enough that I don't mind them showing without a CompletionItemKind.

CFiggers added 2 commits

November 10, 2023 09:25


          Address all Janet :types

3fce7ec


          Include a Judge test

2f1692f

CFiggers merged commit fa70ea6 into CFiggers:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment