Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build a release using cmake #23

Closed
2 tasks done
lrineau opened this issue Mar 24, 2015 · 6 comments
Closed
2 tasks done

Build a release using cmake #23

lrineau opened this issue Mar 24, 2015 · 6 comments

Comments

@lrineau
Copy link
Member

lrineau commented Mar 24, 2015

We really need that script...

Update:
Sébastien said, in #23 (comment):

From what I remember the branch contains two things:

Update:
Issue renamed to Build a release using cmake

@sgiraudot
Copy link
Contributor

Is this still needed today? Who can take care of this?

I can see the branch is still in cgal-dev but seems very old (but was already pretty old when this issue was opened).

@lrineau
Copy link
Member Author

lrineau commented Aug 10, 2016

I know the branch is very old. It was done by Philipp (@bo0ts). I filled the issue not to forget that the code of the branch should be reworked and integrated. That could also be a topic for next meeting.

@sloriot Do you have an opinion on the feature, or the code?

@sloriot
Copy link
Member

sloriot commented Aug 22, 2016

From what I remember the branch contains two things:

  • building a release using CMake
  • ignoring the library configuration tests when only building the documentation
    The reason why the branch was not merged is that the testsuite showed some strange issue on windows that we could not reproduce.

@sloriot
Copy link
Member

sloriot commented Sep 9, 2016

See #1444 that removes the library configuration step if we're interested only by building the doc

@lrineau lrineau removed the Stalled label Sep 9, 2016
@lrineau lrineau added this to the 4.10-beta milestone Sep 9, 2016
@sloriot sloriot modified the milestones: 4.10-beta, 4.11 beta Jan 3, 2017
@sloriot sloriot changed the title Merge the branch Installation-make_release-pmoeller Build a release using cmake Jan 6, 2017
@sloriot
Copy link
Member

sloriot commented Jan 13, 2017

@maxGimeno @lrineau Since the remaining files in dont_submit are neither headers, nor examples/demos files this is no longer a blocking point for this issue.

@lrineau
Copy link
Member Author

lrineau commented Dec 5, 2017

Fixed by #2606.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants