Replace include(CTest) by minimal usage #3657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Define the option `BUILD_TESTING` - Call to `enable_testing()` if `BUILD_TESTING` is on.
lrineau
added
Enhancement
CMake scripts
rm only: release blocker
|
I'll wait for travis's results before I put it in integration. |
|
Successfully tested in https://cgal.geometryfactory.com/CGAL/testsuite/results-4.14-Ic-116.shtml |
lrineau
added
the
rm only: ready for master
lrineau
added a commit
that referenced
this pull request
Feb 7, 2019
Replace include(CTest) by minimal usage
lrineau
removed
rm only: ready for master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Fix the troublesome extra targets created by
CTest.cmake(see StackOverflow).Instead of including
CTest.cmake:BUILD_TESTINGenable_testing()ifBUILD_TESTINGis on.Release Management
That is a fix, but for a minor issue. I prefer not to backport the fix to release branches.