Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polyhedron demo: fix the plane_item's equation #3773

Merged
merged 2 commits into from
Mar 19, 2019
Merged

Polyhedron demo: fix the plane_item's equation #3773

merged 2 commits into from
Mar 19, 2019

Conversation

maxGimeno
Copy link
Contributor

Summary of Changes

Don't forget the offset in the tooltip

Release Management

@maxGimeno maxGimeno self-assigned this Mar 15, 2019
@maxGimeno maxGimeno requested a review from sloriot March 15, 2019 15:04
@lrineau lrineau added this to the 4.14 milestone Mar 18, 2019
sloriot
sloriot approved these changes Mar 19, 2019
View reviewed changes
Copy link
Member

@sloriot sloriot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have much to say, if you checked that the value is now OK (in particular with the point on plane) it is good to go.

@maxGimeno
Copy link
Contributor Author

It seemed goos to me.

@maxGimeno
Copy link
Contributor Author

Successfully tested in https://cgal.geometryfactory.com/CGAL/testsuite/results-4.14-Ic-151.shtml

@lrineau lrineau added rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' and removed Ready to be tested labels Mar 19, 2019
@lrineau lrineau merged commit 3760964 into CGAL:master Mar 19, 2019
lrineau added a commit that referenced this pull request Mar 19, 2019
@lrineau
Merge pull request #3773 from maxGimeno/Demo-Fix_clip_plane_tooltip-GF
49fe08b 
Polyhedron demo: fix the plane_item's equation
@lrineau lrineau removed rm only: ready for release branch For the release team only: that indicates that a PR is about to be merged in a release branch Under Testing labels Mar 19, 2019
@lrineau lrineau deleted the Demo-Fix_clip_plane_tooltip-GF branch March 19, 2019 17:42
@lrineau lrineau removed the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloriot sloriot sloriot approved these changes

Assignees

@maxGimeno maxGimeno

Labels
CGAL 3D demo Merged_in_4.13.2 Merged_in_4.14 Tested
Projects
None yet
Milestone
4.14
Development

Successfully merging this pull request may close these issues.

Plane equation display issue?
4 participants
@maxGimeno @sloriot @MaelRL @lrineau