Add missing header #7742
Merged
Add missing header #7742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CGAL-5.5.x latest test results are completely broken. https://cgal.geometryfactory.com/CGAL/testsuite/results-5.5.4-I-166.shtml That is not due to any code change (there was none since the previous testsuite for 5.5.x). The error are due to Boost 1.84. Probably something change in the includes of Boost. The error is about `boost::prior`. The header `<boost/next_prior.hpp>` must be included.
|
As part of the modernization effort, in master, could we use std::next and std::prev instead? Or do those boost versions have some special behavior? |
The patch is for 5.5.x only. CGAL-5.6.x and |
|
Successfully tested in CGAL-6.0-Ic-84 |
lrineau
added
rm only: ready for master
lrineau
added a commit
that referenced
this pull request
Oct 16, 2023
As the pull-request was for 5.5.x only, this merge does not modify anything.
lrineau
removed
rm only: ready for release branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CGAL-5.5.x latest test results are completely broken.
https://cgal.geometryfactory.com/CGAL/testsuite/results-5.5.4-I-166.shtml
That is not due to any code change (there was none since the previous testsuite for 5.5.x). The error are due to Boost 1.84. Probably something change in the includes of Boost. The error is about
boost::prior. The header<boost/next_prior.hpp>must be included.