PMP::isotropic_remeshing() - add NP allow move functor
#8150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this NP exists in tangential_relaxation() and we want to be able to use it in the relaxation step, from the named parameters of isotropic_remeshing()
janetournois
force-pushed
the
PMP-isotropic_remeshing_with_allow_move_functor-jtournois
branch
from
b32982c
to
96d8e1a
Compare
|
To solve #8134, we can think of a smart functor that would prevent self-intersections from being introduced by the relaxation step |
|
Successfully tested in CGAL-6.0-Ic-235 |
lrineau
added
the
rm only: ready for master
lrineau
deleted the
PMP-isotropic_remeshing_with_allow_move_functor-jtournois
branch
lrineau
removed
the
rm only: ready for master
Should we close the issue #8134, how that this PR is merged, or leave it open? Because it seems the actual solution to #8134 is
|
|
I will post a possible functor in the issue soon! |
lrineau
reviewed
May 17, 2024
| * \cgalParamNBegin{allow_move_functor} | ||
| * \cgalParamDescription{A function object used to determinate if a vertex move should | ||
| * be allowed or not during the relaxation step.} | ||
| * \cgalParamType{Unary functor that provides `bool operator()(vertex_descriptor v, Point_3 src, Point_3 tgt)` |
There was a problem hiding this comment.
Actually, the sentence itself contradicts the word "Unary" (that would take one parameter). That is not a unary functor.
Oops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The function
tangential_relaxation()has a named parameter calledallow_move_functorthat enables the user to prevent and cancel some vertex moves.With this PR, it is now possible to use the same parameter for the relaxation steps of
CGAL::Polygon_mesh_processing::isotropic_remeshing()Release Management