Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tet remeshing - remove assertion in Adaptive sizing field #8378

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

janetournois
Copy link
Member

Summary of Changes

The assertion is invalid (at least) when the function takes a far vertex, inserted by parallel version of Mesh_3.

Release Management

  • Affected package(s): Mesh_3
  • License and copyright ownership: unchanged

it would break for example when the function takes a far vertex, inserted by
parallel version of Mesh_3
@sloriot
Copy link
Member

sloriot commented Jul 25, 2024

Can't you use something like v->is_far() || !edges.empty() ?

@janetournois
Copy link
Member Author

The input triangulation can come from any user code. So there can be more vertices with more different dimensions in the input.

Also, we can think of more cases, depending on how cell_selector is defined. For example, take a vertex of dimension 2 that is not part of the selection, then it has no incident edges that will be pushed in edges, and again the assertion is wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants