Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add thumbnails for redshift parser #554

Closed

Conversation

Anti-Distinctlyminty
Copy link
Contributor

Adds the ability for previews to be generated by Redshift.

Tested on Windows 10 with

  • Houdini-19.5.368 + redshift-3.5.09
  • Houdini-19.0.561 + redshift-3.0.67

@eoyilmaz
Copy link
Member

I don’t think this is a good way of generating the thumbnails, with your implementation, there is no way to disable it, also the Afanasy ROP node has an option to enable thumbnail generation, which already works without a problem, so I vote on not accepting this PR

@eoyilmaz eoyilmaz closed this Nov 26, 2022
@eoyilmaz eoyilmaz self-requested a review November 26, 2022 15:02
@Anti-Distinctlyminty
Copy link
Contributor Author

Ok. It could be that I'm new to Afanasy, but I could never get them to work. See: https://forum.cgru.info/viewtopic.php?t=3492

@timurhai
Copy link
Member

Hi!

I have answered on forum. You can fix it and check manually.

btw
If re_image = re.compile(r"Saving:\s(.+)"), this is printed on the image saving? So, after the render?
So, the should be False: self.appendFile(file_path.strip(), True).
True means generate files "on-the-fly" - during parsing.
This is used mostly on movies encoding/decoding, archives creating/extracting with images.
"on-the-fly" should not be used after the render, as it is not designed/optimized for this.
(It will be processed in the main thread that designed for parsing other things, but better to generate images in a special thread.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants