Some improvements #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We complete only the current level matched (including trailing slash) when the filter string is a prefix of the matched item. For example if the item is `foo/bar/baz` and we type `f⇥` then it gets completed to `foo/` and pressing tab again will make it `foo/bar/` etc.
When items have a UID then Alfred can remember what items we previously picked for an abbreviation.
Also add info.plist taken from the current pass.alfredworkflow archive (which should probably be deleted from the repository).
One minor difference is that Alfred uses straight quotes around the ellipsis, but this should probably be changed in Alfred (rather than us adopting this legacy computer quoting style).
|
Again, great stuff, thanks! I'll remove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did a few more tweaks, if you don’t want all the commits you can always cherry-pick (I didn’t want to create four pull requests for this).
I also added a Makefile to create the
pass.alfredworkflowarchive, I think the current archive should be deleted from the repository because it’s generated from repository content and will be out of sync, but it does mean that people can’t just download the repository and double-click (you’ll need to do releases, but it seems you already do that for the packal stuff).Question:
pass-show.shusesawkandpbcopy. Any reason for avoidingpass -c? Is it the auto-clearing of the clipboard (which I personally quite like, but which can be changed by setting thePASSWORD_STORE_CLIP_TIMEenvironment variable).