Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small README.md updates + a flaky_tests file #111

Closed
wants to merge 2 commits into from

Conversation

pjaaskel
Copy link
Collaborator

No description provided.

@@ -118,6 +99,7 @@ Compiling a HIP application with CHIP-SPV will allow you to execute HIP code on
You can find various HIP applications here: <https://github.com/CHIP-SPV/hip-testsuite>

```bash
export HIP_PLATFORM=spirv
Copy link
Collaborator

@linehill linehill Aug 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not be needed. hipcc looks for $HIP_PATH/lib/.hipInfo which defines HIP_PLATFORM=spirv and other important variables.

(If HIP_PATH is not defined it defaults to <path-to-hipcc>/..).

@franz
Copy link
Collaborator

franz commented Aug 17, 2022

@pjaaskel I've added your README changes to my PR. Please push directly into that branch (& notify me) if you have more documentation updates. WRT the issue not requiring both backends, there's a fix in that PR. WRT the flaky tests, cat ../flaky_tests assumes that the build is subdir of source. I've instead added a custom target named "check" (like in pocl) that skips failing tests with a regexp. If you run into more failing tests, please add them to the regexp (i'll add some more too).

@franz franz closed this Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants