feat: Add confirmation before deleting mods #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There seems to be a crash when deleting the last mod in the list
|
I noticed, while using this change with a larger mod list, that displaying the confirmation seems to try to scroll until the mod you are trying to delete is at the bottom of the window. I am not sure what is causing that to happen or how to go about fixing that at this time. |
This still does not fix the scroll jumping issue
|
I thought it might be related to immediately creating the modal within the for loop generating the rows, but moving it outside of the for loop did not seem to fix it. I think I am out of possible ideas on how to fix the scroll issue, so, unless someone else has ideas, I think this is as far as I go on this pull. |
CHollingworth
added a commit
that referenced
this pull request
Dec 11, 2023
This reverts commit ab3e358.
CHollingworth
added a commit
that referenced
this pull request
Dec 11, 2023
CHollingworth
pushed a commit
that referenced
this pull request
Dec 16, 2023
🤖 I have created a release *beep* *boop* --- ## [1.3.0](v1.2.0...v1.3.0) (2023-12-16) ### Features * Add confirmation before deleting mods ([#89](#89)) ([ab3e358](ab3e358)) * Add confirmation before deleting mods ([#98](#98)) ([fd72f1a](fd72f1a)) * Add context menu for moving mods to top or bottom ([#93](#93)) ([e5303d3](e5303d3)) * Add mod separators ([#94](#94)) ([79e8d55](79e8d55)) * Add quit button to the menu ([#99](#99)) ([62d778c](62d778c)) ### Bug Fixes * Added proper credit to contributors, they do amazing work please give em love. ([9c30861](9c30861)) * BG3 now functions. (First Push of LHL) ([a7b1848](a7b1848)) * Cyberpunk deployment will now deploy all files. ([188c44f](188c44f)) * Fix installing REDMod into the /mods directory ([#100](#100)) ([0b20181](0b20181)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a confirmation modal/dialogue box to inform users that the action cannot be undone and to have them confirm that they want to delete the mod.
This should help prevent accidental deletions by users.
We may want to do some additional tweaking, such as changing button colors to help differentiate them.