Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add quit button to the menu #99

Merged
merged 2 commits into from
Dec 16, 2023

Conversation

SnazzyPanda
Copy link
Contributor

Adds a quit button to the main menu.

This option may feel nicer to some users over requiring the use of the close button on the window.

I was hoping for a somewhat 'cleaner' way of doing this (such as by manually triggering an SDL_QUIT event from the menu), but I have not yet figured out if that is possible. If you have a better way of handling this, feel free to close this PR or let me know. Otherwise, I believe this should work fine.

@CHollingworth CHollingworth merged commit 62d778c into CHollingworth:master Dec 16, 2023
2 checks passed
CHollingworth pushed a commit that referenced this pull request Dec 16, 2023
🤖 I have created a release *beep* *boop*
---


##
[1.3.0](v1.2.0...v1.3.0)
(2023-12-16)


### Features

* Add confirmation before deleting mods
([#89](#89))
([ab3e358](ab3e358))
* Add confirmation before deleting mods
([#98](#98))
([fd72f1a](fd72f1a))
* Add context menu for moving mods to top or bottom
([#93](#93))
([e5303d3](e5303d3))
* Add mod separators
([#94](#94))
([79e8d55](79e8d55))
* Add quit button to the menu
([#99](#99))
([62d778c](62d778c))


### Bug Fixes

* Added proper credit to contributors, they do amazing work please give
em love.
([9c30861](9c30861))
* BG3 now functions. (First Push of LHL)
([a7b1848](a7b1848))
* Cyberpunk deployment will now deploy all files.
([188c44f](188c44f))
* Fix installing REDMod into the /mods directory
([#100](#100))
([0b20181](0b20181))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@SnazzyPanda SnazzyPanda deleted the add-quit-to-menu branch December 16, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants