Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getTemp throws error when invalid API Key is used #30

Closed
mastasky opened this issue Dec 26, 2019 · 5 comments
Closed

getTemp throws error when invalid API Key is used #30

mastasky opened this issue Dec 26, 2019 · 5 comments
Assignees

Comments

@mastasky
Copy link

mastasky commented Dec 26, 2019

Since the function tries to access a deeply nested value which doesn't exist, we get an exception which isn't caught and forwarded to the callback.

return callback(err,jsonObj.main.temp);

Repro:

  • Create a script that instantatias weather with an invalid API key
  • Call the getTemperature function
@jemxz
Copy link

jemxz commented Mar 17, 2020

This error also occurs when a valid API key is used. Is there a fix to it?

@CICCIOSGAMINO
Copy link
Owner

I'm working on ...

@CICCIOSGAMINO
Copy link
Owner

Solved in the next version ... i'll be v5.0.0

@jemxz
Copy link

jemxz commented Mar 18, 2020 via email

@bayoudhi
Copy link

bayoudhi commented Jan 3, 2021

Hello guys, I think this issue is already fixed in this merged PR #41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants